fix: building node modules with Visual Studio 2017

[miniak]

Description of Change

Build error occurs due to this in Visual Studio 2017:

/**
 * Weakness type for weak handles.
 */
enum class WeakCallbackType {
  /**
   * Passes a user-defined void* parameter back to the callback.
   */
  kParameter,
  /**
   * Passes the first two internal fields of the object back to the callback.
   */
  kInternalFields,
  /**
   * Passes a user-defined void* parameter back to the callback. Will do so
   * before the object is actually reclaimed, allowing it to be resurrected. In
   * this case it is not possible to set a second-pass callback.
   */
  kFinalizer V8_ENUM_DEPRECATED("Resurrecting finalizers are deprecated "
                                "and will not be supported going forward.")
};

In Electron 18, this was previously:

enum class WeakCallbackType { kParameter, kInternalFields, kFinalizer };

Follow-up to #34109

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed building node modules with Visual Studio 2017

[deepak1556]

Attribute support for enumerators comes with /std:c++17 in msvc https://docs.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-170, can you try building with it ?

[miniak]

Attribute support for enumerators comes with /std:c++17 in msvc https://docs.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-170, can you try building with it ?

I will try, but for some reason in Visual Studio 2019 it works without /std:c++17.

[ckerr]

Attribute support for enumerators comes with /std:c++17 in msvc https://docs.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-170, can you try building with it ?

I will try, but for some reason in Visual Studio 2019 it works without /std:c++17.

V8 has added more C++17isms into its headers recently and that held up the Chromium roll for a bit last week. Since we'll all need to be building with --std=c++17 anyway, I'm not sure this patch is the right fix?

[miniak]

@ckerr I've tried building our node modules with /std:c++latest on Visual Studio 2017 and it's still broken.

[release-clerk]

Release Notes Persisted

Fixed building node modules with Visual Studio 2017

[trop]

I have automatically backported this PR to "19-x-y", please check out #34316