chore: add a TRACE call for crash_reporter::Start()
#34268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing the crashReporter takes around 620 milliseconds on Intel macOS. I have sent a CL to crashpad to partially fix the performance issue in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386. It would be beneficial to log the performance impact of this function in the traces in case this slows down in the future. Signed-off-by: Darshan Sen <raisinten@gmail.com>
bavulapati
reviewed
May 18, 2022
|
I think this is semver-minor, so shouldn't this be backported to all the supported release lines? |
|
@RaisinTen this doesn't affect the API surfaced to end users, so we'd classify this as |
codebytere
approved these changes
May 23, 2022
VerteDinde
approved these changes
May 23, 2022
|
Release Notes Persisted
|
This was referenced May 23, 2022
|
I have automatically backported this PR to "17-x-y", please check out #34324 |
|
I have automatically backported this PR to "18-x-y", please check out #34325 |
|
I have automatically backported this PR to "19-x-y", please check out #34326 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
chore: add a TRACE call for crash_reporter::Start() Initializing the crashReporter takes around 620 milliseconds on Intel macOS. I have sent a CL to crashpad to partially fix the performance issue in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386. It would be beneficial to log the performance impact of this function in the traces in case this slows down in the future. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Initializing the crashReporter takes around 620 milliseconds on Intel
macOS. I have sent a CL to crashpad to partially fix the performance
issue in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386.
It would be beneficial to log the performance impact of this function in
the traces in case this slows down in the future.
Signed-off-by: Darshan Sen raisinten@gmail.com
Checklist
npm testpassesRelease Notes
Notes: Added a TRACE call named
crash_reporter::Startunder theelectroncategory forcrash_reporter::Start().