Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DCHECK on webContents.print() #34271

Merged
merged 2 commits into from May 19, 2022
Merged

fix: DCHECK on webContents.print() #34271

merged 2 commits into from May 19, 2022

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 18, 2022 •
edited

Description of Change

Closes #34270.
Refs CL:3579297

Fixes a DCHECK when calling webContents.print().

Tested with https://gist.github.com/0f0e776b138452d6815ef4efc16aa0d1

Checklist

Release Notes

Notes: Fixed a potential crash when calling webContents.print()

@codebytere codebytere added the semver/patch backwards-compatible bug fixes label May 18, 2022
@codebytere codebytere requested review from a team as code owners May 18, 2022 10:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 18, 2022
@codebytere codebytere mentioned this pull request May 18, 2022
Merged
5 tasks
@codebytere
Copy link
Member Author

Failure:

BrowserWindow module BrowserWindow.setTitlebarOverlay correctly updates the height of the overlay

is unrelated.

@codebytere codebytere merged commit 588005a into main May 19, 2022
@codebytere codebytere deleted the fix-print-dcheck branch May 19, 2022 08:05
@release-clerk
Copy link

release-clerk bot commented May 19, 2022

Release Notes Persisted

Fixed a potential crash when calling webContents.print()

@codebytere codebytere mentioned this pull request May 20, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 20, 2022

@codebytere has manually backported this PR to "19-x-y", please check out #34299

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@pushkin- pushkin- mentioned this pull request May 26, 2022
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request Jul 26, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: DCHECK on webContents.print() (electron#34271)
94d7f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DCHECK on webContents.print()
4 participants
@codebytere @ckerr @jkleinsc @VerteDinde