Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on navigator.serial.getPorts() #34280

Merged
merged 2 commits into from May 23, 2022
Merged

fix: crash on navigator.serial.getPorts() #34280

merged 2 commits into from May 23, 2022

Conversation

jkleinsc
Copy link
Contributor

Description of Change

While working on implementing SerialPort.forget(), I found a crash caused by #32651.

Checklist

Release Notes

Notes: fixed crash when calling navigator.serial.getPorts()

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 19, 2022
@jkleinsc jkleinsc added target/15-x-y semver/patch backwards-compatible bug fixes labels May 19, 2022
codebytere
codebytere previously approved these changes May 19, 2022
@codebytere codebytere dismissed their stale review May 19, 2022 08:13

test failures

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Windows failures are legitimate

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@jkleinsc jkleinsc merged commit 887b5a7 into main May 23, 2022
@jkleinsc jkleinsc deleted the fixup-serial-crash branch May 23, 2022 14:33
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

fixed crash when calling navigator.serial.getPorts()

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/15-x-y label May 23, 2022
@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/17-x-y label May 23, 2022
@trop
Copy link
Contributor

trop bot commented May 23, 2022

@jkleinsc has manually backported this PR to "19-x-y", please check out #34323

@trop
Copy link
Contributor

trop bot commented May 23, 2022

@jkleinsc has manually backported this PR to "18-x-y", please check out #34327

@trop
Copy link
Contributor

trop bot commented May 23, 2022

@jkleinsc has manually backported this PR to "17-x-y", please check out #34328

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* fix: crash on navigator.serial.getPorts()

* test: fixup BrowserWindow.setTitlebarOverlay test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: navigator.serial.requestPort crashing app
2 participants