New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash on navigator.serial.getPorts() #34280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Windows failures are legitimate
fb308b3
to
9a277f7
Compare
9a277f7
to
86af05f
Compare
Release Notes Persisted
|
I was unable to backport this PR to "16-x-y" cleanly; |
I was unable to backport this PR to "15-x-y" cleanly; |
I was unable to backport this PR to "17-x-y" cleanly; |
I was unable to backport this PR to "18-x-y" cleanly; |
I was unable to backport this PR to "19-x-y" cleanly; |
* fix: crash on navigator.serial.getPorts() * test: fixup BrowserWindow.setTitlebarOverlay test
Description of Change
While working on implementing SerialPort.forget(), I found a crash caused by #32651.
Checklist
npm test
passesRelease Notes
Notes: fixed crash when calling navigator.serial.getPorts()