fix: service worker registration with custom protocols #34290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deepak1556 has manually backported this PR to "18-x-y", please check out #34291 |
deepak1556
added
semver/patch
|
This would be great to have! |
codebytere
approved these changes
May 21, 2022
VerteDinde
approved these changes
May 23, 2022
|
Failing test is unrelated, merging. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "19-x-y", please check out #34315 |
YuriL180821
pushed a commit
to YuriL180821/electron
that referenced
this pull request
Sep 25, 2022
…ron#34290)" This reverts commit 1639ccf. # Conflicts: # patches/chromium/custom_protocols_plzserviceworker.patch
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #32664
Release Notes
Notes: fix service worker registration with custom protocols