revert: add first-instance-ack event to the app.requestSingleInstanceLock() flow
#34297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngleInstanceLock()` flow"
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
nornagon
approved these changes
May 19, 2022
|
API LGTM |
|
@VerteDinde has manually backported this PR to "18-x-y", please check out #34295 |
codebytere
changed the title
app.requestSingleInstanceLock() flow"app.requestSingleInstanceLock() flow
codebytere
approved these changes
May 20, 2022
deepak1556
approved these changes
May 20, 2022
3 tasks
MarshallOfSound
approved these changes
May 22, 2022
MarshallOfSound
added
the
fast-track 🚅
electron-cation
bot
removed
new-pr 🌱
3 tasks
|
WOA failure is a flake and unrelated |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
@VerteDinde has manually backported this PR to "19-x-y", please check out #34312 |
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…eLock()` flow (electron#34297) fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33566
PR #31460 added a new
first-instance ackevent, which uses named pipes under the hood. However, named pipes are not session-specific like the window and mutex objects that are used to synchronize/communicate between processes. Because of this, pipes meant for one app will collide with another and cause a deadlock. (A fix for this was attempted in #34139)Even after making the named pipes session-specific, there is still a race condition where if multiple "second instances" of different Electron apps (or of the same app) run at the same time, they could get acks meant for other ones. This means that two Electrons apps with the same name, being used by the same user, could collide as long as one us using Electron 18+. We were also seeing this issue with a single Electron app creating a second instance, such as an HTML notification window.
There's a plan to refactor this to move away from named pipes and use MessageWindow instead (see #34235). Because Electron 19 is close to stable release, and more users will be upgrading to both Electron 19 and Electron 18, we've decided to revert the original named pipe change and reland a future refactor using MessageWindow. This PR reverts the original change.
Checklist
npm testpassesRelease Notes
Notes: Notes: Fixed an issue where running second instances of the same application would cause a deadlock on Windows.