Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when loading extension with missing manifest #34303

Merged
merged 1 commit into from May 23, 2022
Merged

fix: crash when loading extension with missing manifest #34303

merged 1 commit into from May 23, 2022

Conversation

codebytere
Copy link
Member

Backport of #34168.

See that PR for details.

Notes: Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

@codebytere codebytere requested a review from a team May 20, 2022 20:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@trop trop bot mentioned this pull request May 20, 2022
Merged
4 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 20, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@VerteDinde
Copy link
Member

win-ia32 has passed, GH just didn't update

@VerteDinde VerteDinde merged commit f9dc5b5 into 19-x-y May 23, 2022
@VerteDinde VerteDinde deleted the fix-malformed-extension-crash-19 branch May 23, 2022 02:32
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @VerteDinde @MarshallOfSound