Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when loading extension with missing manifest #34304

Merged
merged 1 commit into from May 23, 2022

Conversation

codebytere
Copy link
Member

Backport of #34168.

See that PR for details.

Notes: Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

@codebytere codebytere requested a review from a team May 20, 2022 20:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 20, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 20, 2022
@codebytere codebytere requested a review from jkleinsc May 23, 2022 12:51
@jkleinsc jkleinsc merged commit 02bf71f into 18-x-y May 23, 2022
@jkleinsc jkleinsc deleted the fix-malformed-extension-crash-18 branch May 23, 2022 14:43
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants