Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service worker registration with custom protocols #34315

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 23, 2022

Backport of #34290

See that PR for details.

Notes: fix service worker registration with custom protocols

@trop trop bot requested review from a team as code owners May 23, 2022 07:43
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@trop trop bot requested a review from deepak1556 May 23, 2022 07:43
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@codebytere
Copy link
Member

@deepak1556 can you force push this? looks like circle didn't run.

@deepak1556 deepak1556 force-pushed the trop/19-x-y-bp-fix-service-worker-registration-with-custom-protocols-1653291778881 branch from 36fcd81 to 4f82e5f Compare May 23, 2022 12:15
@VerteDinde VerteDinde merged commit 0206a9b into 19-x-y May 23, 2022
@VerteDinde VerteDinde deleted the trop/19-x-y-bp-fix-service-worker-registration-with-custom-protocols-1653291778881 branch May 23, 2022 15:29
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

fix service worker registration with custom protocols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants