Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a TRACE call for crash_reporter::Start() #34324

Merged
merged 1 commit into from May 24, 2022
Merged

chore: add a TRACE call for crash_reporter::Start() #34324

merged 1 commit into from May 24, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 23, 2022

Backport of #34268

See that PR for details.

Notes: Added a TRACE call named crash_reporter::Start under the electron category for crash_reporter::Start().

@RaisinTen @electron-bot
chore: add a TRACE call for crash_reporter::Start()
ac89ae3 
Initializing the crashReporter takes around 620 milliseconds on Intel
macOS. I have sent a CL to crashpad to partially fix the performance
issue in
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386.
It would be beneficial to log the performance impact of this function in
the traces in case this slows down in the future.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@trop trop bot mentioned this pull request May 23, 2022
Merged
3 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@codebytere codebytere merged commit 7529094 into 17-x-y May 24, 2022
@codebytere codebytere deleted the trop/17-x-y-bp-chore-add-a-trace-call-for-crash_reporter-start--1653320300689 branch May 24, 2022 08:21
@release-clerk
Copy link

release-clerk bot commented May 24, 2022

Release Notes Persisted

Added a TRACE call named crash_reporter::Start under the electron category for crash_reporter::Start().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @RaisinTen