Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add immersive dark mode on windows #34549

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 14, 2022

Backport of #33624

See that PR for details.

Notes: Added immersive dark mode on Windows.

* feat: add immersive dark mode

* fix syntax and add header

* add me

* Update fuses.json5

* fix: redraw title bar on dark mode change

* chore: SetWindowTheme doesn't seem to be needed

* chore: separate out Win 10 dark mode implementation

* final touches

* final touches

* chore: limit Win 10 to >= 20H1 and drop fuse

* fix types

* fix lint

Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2022
@trop trop bot requested a review from mlaurencin June 14, 2022 16:28
@trop trop bot mentioned this pull request Jun 14, 2022
4 tasks
@trop trop bot added 20-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jun 14, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2022
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport has been asynchronously approved by wg-releases.

@zcbenz zcbenz merged commit 5b583c8 into 20-x-y Jun 20, 2022
@zcbenz zcbenz deleted the trop/20-x-y-bp-feat-add-immersive-dark-mode-on-windows-1655224067819 branch June 20, 2022 04:33
@release-clerk
Copy link

release-clerk bot commented Jun 20, 2022

Release Notes Persisted

Added immersive dark mode on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants