fix: make preload calculation identical between sandbox & non-sandboxed #34585

trop · 2022-06-15T20:22:45Z

Backport of #34531

See that PR for details.

Notes: Fixed child about:blank windows from inheriting their parents' preload scripts when sandbox: false and nodeIntegrationInSubFrames: true.

release-clerk · 2022-06-20T01:02:53Z

Release Notes Persisted

Fixed child about:blank windows from inheriting their parents' preload scripts when sandbox: false and nodeIntegrationInSubFrames: true.

nornagon added 7 commits June 15, 2022 20:22

fix: make preload calculation identical between sandbox & non-sandboxed

bf17d10

fix test

b22d5b6

split IPCs

593ce2e

fix ipc constant

3807af2

fix unneeded async function

9f5f175

remove unused preloads blink preferences

49930ad

fix typings

9cb85ba

trop bot requested review from a team as code owners June 15, 2022 20:22

trop bot requested a review from nornagon June 15, 2022 20:22

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2022

trop bot mentioned this pull request Jun 15, 2022

fix: make preload calculation identical between sandbox & non-sandboxed #34531

Merged

5 tasks

trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 15, 2022

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2022

codebytere approved these changes Jun 17, 2022

View reviewed changes

zcbenz approved these changes Jun 20, 2022

View reviewed changes

zcbenz merged commit ff7f2a5 into 20-x-y Jun 20, 2022

zcbenz deleted the trop/20-x-y-bp-fix-make-preload-calculation-identical-between-sandbox-non-sandboxed-1655324562842 branch June 20, 2022 01:02

Provide feedback