Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when setWindowOpenHandler callback throws #34627

Merged
merged 1 commit into from Jun 20, 2022
Merged

fix: crash when setWindowOpenHandler callback throws #34627

merged 1 commit into from Jun 20, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 19, 2022

Backport of #34523

See that PR for details.

Notes: Fixed an error where setWindowOpenHandler() would crash if the callback threw an error

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2022
@trop trop bot mentioned this pull request Jun 19, 2022
Merged
4 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 19, 2022
@miniak miniak requested a review from codebytere June 19, 2022 18:57
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2022
@miniak miniak marked this pull request as ready for review June 19, 2022 18:57
@miniak miniak force-pushed the miniak/fix-handler-throw-18-x-y branch from e953380 to c0b4abb Compare June 19, 2022 19:00
@miniak miniak self-assigned this Jun 19, 2022
@zcbenz zcbenz merged commit 4995551 into 18-x-y Jun 20, 2022
@zcbenz zcbenz deleted the miniak/fix-handler-throw-18-x-y branch June 20, 2022 00:35
@release-clerk
Copy link

release-clerk bot commented Jun 20, 2022

Release Notes Persisted

Fixed an error where setWindowOpenHandler() would crash if the callback threw an error

@miniak
Copy link
Contributor Author

miniak commented Jun 25, 2022

/trop run backport-to 17-x-y

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

The backport process for this PR has been manually initiated - sending your PR to 17-x-y!

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

@miniak miniak

Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @codebytere