Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance problem in crashReporter.start() on macOS #34639

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 20, 2022

Backport of #34609

See that PR for details.

Notes: Fixes a performance problem in crashReporter.start() on macOS.

This change reduces the duration of crashReporter.start() on Intel macOS
from 622 milliseconds to 257 milliseconds!

Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386

  posix: Replace DoubleForkAndExec() with ForkAndSpawn()

  The DoubleForkAndExec() function was taking over 622 milliseconds to run
  on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
  some custom traces and found that the fork() syscall is the bottleneck
  here, i.e., the first fork() takes around 359 milliseconds and the
  nested fork() takes around 263 milliseconds. Replacing the nested fork()
  and exec() with posix_spawn() reduces the time consumption to 257
  milliseconds!

  See libuv/libuv#3064 to know why fork() is so
  slow on macOS and why posix_spawn() is a better replacement.

  Another point to note is that even base::LaunchProcess() from Chromium
  calls posix_spawnp() on macOS -
  https://source.chromium.org/chromium/chromium/src/+/8f8d82dea0fa8f11f57c74dbb65126f8daba58f7:base/process/launch_mac.cc;l=295-296

  Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26
  Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
  Reviewed-by: Mark Mentovai <mark@chromium.org>
  Commit-Queue: Mark Mentovai <mark@chromium.org>

Fixes: #34321
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@trop trop bot requested review from a team as code owners June 20, 2022 04:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2022
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 20, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2022
@zcbenz zcbenz merged commit 2b2900a into 20-x-y Jun 21, 2022
@zcbenz zcbenz deleted the trop/20-x-y-bp-fix-performance-problem-in-crashreporter-start-on-macos-1655699552891 branch June 21, 2022 01:40
@release-clerk
Copy link

release-clerk bot commented Jun 21, 2022

Release Notes Persisted

Fixes a performance problem in crashReporter.start() on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants