Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: only create webContents after 'will-attach-webview' #35016

Merged
merged 1 commit into from Jul 25, 2022
Merged

refactor: only create webContents after 'will-attach-webview' #35016

merged 1 commit into from Jul 25, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 21, 2022

Backport of #32941

See that PR for details.

Notes: WebContents for <webview> are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

@trop trop bot requested a review from a team as a code owner July 21, 2022 09:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 21, 2022
@trop trop bot requested a review from miniak July 21, 2022 09:29
@trop trop bot mentioned this pull request Jul 21, 2022
Merged
4 tasks
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 21, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 21, 2022
@codebytere codebytere merged commit 4f3be68 into 20-x-y Jul 25, 2022
@codebytere codebytere deleted the trop/20-x-y-bp-refactor-only-create-webcontents-after-will-attach-webview--1658395783355 branch July 25, 2022 08:11
@release-clerk
Copy link

release-clerk bot commented Jul 25, 2022

Release Notes Persisted

WebContents for &lt;webview&gt; are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @codebytere