Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly fire serial-port-added and serial-port-removed events #35047

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 25, 2022

Backport of #34958

See that PR for details.

Notes: fixed serial-port-added and serial-port-removed events not firing.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@trop trop bot requested a review from jkleinsc July 25, 2022 14:51
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@jkleinsc jkleinsc merged commit 3a079fe into 20-x-y Jul 25, 2022
@jkleinsc jkleinsc deleted the trop/20-x-y-bp-fix-properly-fire-serial-port-added-and-serial-port-removed-events-1658760646996 branch July 25, 2022 20:37
@release-clerk
Copy link

release-clerk bot commented Jul 25, 2022

Release Notes Persisted

fixed serial-port-added and serial-port-removed events not firing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant