Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inertial scroll is broken when the scrollable element has an overlay with pointer-events: none #35051

Merged
merged 1 commit into from Jul 26, 2022
Merged

fix: inertial scroll is broken when the scrollable element has an overlay with pointer-events: none #35051

merged 1 commit into from Jul 26, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 25, 2022

Description of Change

Fixes #35049
Backport: https://chromium-review.googlesource.com/c/chromium/src/+/3681882

Checklist

Release Notes

Notes: Fixed inertial scroll is broken when the scrollable element has an overlay with pointer-events: none.

@miniak miniak requested review from a team as code owners July 25, 2022 21:27
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@miniak miniak linked an issue Jul 25, 2022 that may be closed by this pull request
[Bug]: scrolling stops with virtual scroll #35049
Closed
3 tasks
@miniak miniak added the backport-check-skip Skip trop's backport validity checking label Jul 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@miniak miniak added semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Jul 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
nornagon
nornagon reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was landed in 104. Does this also need to be backported to 20.x?

@miniak
Copy link
Contributor Author

miniak commented Jul 25, 2022

@nornagon I can only reproduce this issue with 19-x-y

@deepak1556 deepak1556 merged commit f3f1171 into 19-x-y Jul 26, 2022
@deepak1556 deepak1556 deleted the miniak/fix-scrolling-19-x-y branch July 26, 2022 02:30
@release-clerk
Copy link

release-clerk bot commented Jul 26, 2022

Release Notes Persisted

Fixed inertial scroll is broken when the scrollable element has an overlay with pointer-events: none.

@codebytere codebytere mentioned this pull request Jul 26, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
19-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: scrolling stops with virtual scroll
3 participants
@miniak @nornagon @deepak1556