Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setsize to be called within a move or resize for preventDefault #35083

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 27, 2022

Backport of #34843

See that PR for details.

Notes: Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 27, 2022
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 27, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 27, 2022
@codebytere codebytere merged commit 729b0f5 into 19-x-y Jul 27, 2022
@codebytere codebytere deleted the trop/19-x-y-bp-fix-allow-setsize-to-be-called-within-a-move-or-resize-for-preventdefault-1658880152076 branch July 27, 2022 09:42
@release-clerk
Copy link

release-clerk bot commented Jul 27, 2022

Release Notes Persisted

Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants