Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sandbox preloads by default #35125

Merged
merged 1 commit into from Jul 29, 2022
Merged

feat: sandbox preloads by default #35125

merged 1 commit into from Jul 29, 2022

Conversation

VerteDinde
Copy link
Member

Manual backport of #32869

See that PR for details.

Notes: Notes: Renderers are now sandboxed by default unless nodeIntegration: true or sandbox: false is specified.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@trop trop bot mentioned this pull request Jul 29, 2022
Merged
5 tasks
@trop trop bot added 20-x-y backport This is a backport PR backport/requested 🗳 semver/major incompatible API changes labels Jul 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@codebytere codebytere changed the title feat: sandbox preloads by default (#32869) feat: sandbox preloads by default Jul 29, 2022
VerteDinde
VerteDinde commented Jul 29, 2022
View reviewed changes
Copy link
Member Author

@VerteDinde VerteDinde left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was already approved by the Releases WG for 20-x-y, it was just not merged before the branch cut occurred - going to merge 👍

@VerteDinde VerteDinde merged commit 08aa578 into 20-x-y Jul 29, 2022
@VerteDinde VerteDinde deleted the backport-20-x-y-sandbox-preloads branch July 29, 2022 22:06
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2022

Release Notes Persisted

Notes: Renderers are now sandboxed by default unless nodeIntegration: true or sandbox: false is specified.

@erickzhao erickzhao mentioned this pull request Aug 18, 2022
Merged
3 tasks
@hermit99 hermit99 mentioned this pull request Aug 22, 2022
Closed
@Prinzhorn Prinzhorn mentioned this pull request Sep 6, 2022
Closed
3 tasks
@smrutiparida smrutiparida mentioned this pull request Sep 23, 2022
Closed
This was referenced Nov 24, 2022
Closed
Closed
@yanguoyu yanguoyu mentioned this pull request Dec 13, 2022
Closed
@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
@valefar-on-discord valefar-on-discord mentioned this pull request Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
20-x-y backport/requested 🗳 backport This is a backport PR semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VerteDinde @codebytere @nornagon