Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up callback handling in webContents.print() #35141

Merged
merged 1 commit into from Aug 1, 2022

Conversation

codebytere
Copy link
Member

Backport of #34894.

See that PR for details.

Notes: Fixed an issue where invalid print job settings would correctly call back Invalid print settings as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit.

@codebytere codebytere requested review from a team as code owners July 29, 2022 21:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@github-actions
Copy link
Contributor

electron-woa-testing

    1 files  178 suites   1m 58s ⏱️
380 tests 380 ✔️ 0 💤 0
415 runs  415 ✔️ 0 💤 0

Results for commit 654aab2.

@VerteDinde VerteDinde merged commit 0e6f172 into 20-x-y Aug 1, 2022
@VerteDinde VerteDinde deleted the better-print-reason-20 branch August 1, 2022 14:41
@release-clerk
Copy link

release-clerk bot commented Aug 1, 2022

Release Notes Persisted

Fixed an issue where invalid print job settings would correctly call back Invalid print settings as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants