Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify file extension generation on Windows #35171

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 2, 2022

Backport of #34723

See that PR for details.

Notes: None

* fix: modify file extension generation on Windows

* modify includes

* include vector in header

* add win build flags

* remove hardcoded strings

* Update shell/browser/electron_download_manager_delegate.h

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix string manipulation and function definitions

* Update electron_download_manager_delegate.h

* convert to std::string and modify for electron

* Update shell/browser/electron_download_manager_delegate.cc

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* remove vector include and update conversion

* add vectr include for lint

Co-authored-by: Charles Kerr <charles@charleskerr.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2022
@trop trop bot requested a review from mlaurencin August 2, 2022 00:40
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 2, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Aug 2, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 56a0b45 into 18-x-y Aug 2, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-fix-modify-file-extension-generation-on-windows-1659400838648 branch August 2, 2022 19:54
@release-clerk
Copy link

release-clerk bot commented Aug 2, 2022

Release Notes Persisted

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants