Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 94a8bdafc8c6 from chromium #35237

Merged
merged 2 commits into from Aug 8, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 4, 2022

Fix use-after-free vulnerability in ComboboxModel

Stop the Combobox from observing the model when the model gets
destroyed. This is done by adding a virtual OnComboboxModelDestroying()
to the base observer class and calling it in ~ComboboxModel().

This fix will prevent the use-after-free that happens when the combobox outlives the model, usually because the model lifetime
is managed by non-UI component.

Bug: 1264288
Change-Id: Ia00881a9b674bbc83bbf54dd228490c1cc1290bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3693825
Commit-Queue: Keren Zhu kerenzhu@chromium.org
Reviewed-by: Matthias Körber koerber@google.com
Auto-Submit: Keren Zhu kerenzhu@chromium.org
Reviewed-by: Peter Boström pbos@chromium.org
Cr-Commit-Position: refs/heads/main@{#1012504}

Notes: Security: backported fix for 1264288.

@nornagon nornagon requested review from a team as code owners August 4, 2022 22:28
@nornagon nornagon added 19-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Aug 4, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 4, 2022
@codebytere codebytere merged commit fb6de2d into 19-x-y Aug 8, 2022
@codebytere codebytere deleted the cherry-pick/19-x-y/chromium/94a8bdafc8c6 branch August 8, 2022 07:57
@release-clerk
Copy link

release-clerk bot commented Aug 8, 2022

Release Notes Persisted

Security: backported fix for 1264288.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants