Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick bd9724c9fe63 from chromium #35275

Merged
merged 3 commits into from Aug 9, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Aug 9, 2022

[M104][Background fetch] passing update_first_party_url_on_redirect=false for fetch

Background fetch doesn't work like regular download as it is not
considered a top frame navigation. This CL let background fetch to
pass update_first_party_url_on_redirect=false to DownloadURLParameters,
and handle it properly w.r.t samesite cookies.

BUG=1268580

(cherry picked from commit bf1e93c6af21dad12088b615feda07a90a85c158)

Change-Id: I3a1cc33be8578d5d8c796dbbb21fa35a47bdda36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3712307
Reviewed-by: Rayan Kanso rayankans@chromium.org
Commit-Queue: Min Qin qinmin@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1016316}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727786
Cr-Commit-Position: refs/branch-heads/5112@{#397}
Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}

Notes: Security: backported fix for CVE-2022-2615.

@ppontes ppontes requested review from a team as code owners August 9, 2022 00:04
@ppontes ppontes added 19-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Aug 9, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 9, 2022
@jkleinsc jkleinsc merged commit bf7741a into 19-x-y Aug 9, 2022
@jkleinsc jkleinsc deleted the cherry-pick/19-x-y/chromium/bd9724c9fe63 branch August 9, 2022 18:33
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2022

Release Notes Persisted

Security: backported fix for CVE-2022-2615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants