[BUG]: Cannot download electron

[BlackHole1]

During the download, I found that SHASUMS256.txt was a bunch of useless strings, causing the checksum to fail.

1.mp4

I have confirmed through git bisect start HEAD 3aa1e64 that the problem is caused by #1109 PR. But it is not clear why this is the case.

CC: @erickzhao @dsanders11 @aryanshridhar

[BlackHole1]

Additions from @aryanshridhar :

I am only able to reproduce this when I set the electron mirrors to CHINA under settings.
(It works fine if I set it to DEFAULT)

[BlackHole1]

I used the following code for the simulation but could not reproduce it.

const fs = require("fs");
const got = require("got");
const url = "https://npmmirror.com/mirrors/electron/v19.0.6/SHASUMS256.txt";
const gotOptions = {
    timeout: {
        connect: 15000,
        lookup: 15000,
        response: 15000,
        socket: 15000,
    },
}
const targetFilePath = "/Users/black-hole/1/SHASUMS256.txt";
const writeStream = fs.createWriteStream(targetFilePath);
const downloadStream = got.stream(url, gotOptions)

downloadStream.on('downloadProgress', async (progress) => {
    console.log(progress);
});
downloadStream.on('error', error => {
    if (writeStream.destroy) {
        writeStream.destroy(error);
    }
    console.error("download error", error);
});
writeStream.on('error', error => {
    console.log("file error", error);
});
writeStream.on('close', () => {
    console.log("close")
});

downloadStream.on("data", data => {
    console.log(data.toString());
})

downloadStream.pipe(writeStream);

Even if I put the code in devtools and execute it, it works fine.

[BlackHole1]

I know what the content represents now. This is gzip content. Now it's just a matter of determining why gzip decompression is not being performed here to see what the problem is.

[BlackHole1]

This was a bug in got that has been fixed in the new version of got, I will submit a PR for electron/get tomorrow

See: sindresorhus/got#1105 / sindresorhus/got#945

This bug is only triggered in the electron-renderer and when Webpack is packaged.

This also explains why the code I wrote to reproduce the problem was not reproducible

Fuck. It took me a whole day to fix this problem.