From 92817f4d5314dc65a70db5a3dad5f5ba28da2c68 Mon Sep 17 00:00:00 2001
From: Mark Lee <malept@users.noreply.github.com>
Date: Mon, 25 Nov 2019 18:05:11 -0800
Subject: [PATCH] test: remove rebuild tests that duplicate electron-rebuild
 (#1303)

---
 .../core/test/fixture/native_app/package.json | 27 -------
 .../api/core/test/slow/rebuild_spec_slow.ts   | 81 -------------------
 2 files changed, 108 deletions(-)
 delete mode 100644 packages/api/core/test/fixture/native_app/package.json
 delete mode 100644 packages/api/core/test/slow/rebuild_spec_slow.ts

diff --git a/packages/api/core/test/fixture/native_app/package.json b/packages/api/core/test/fixture/native_app/package.json
deleted file mode 100644
index 17e0358b28..0000000000
--- a/packages/api/core/test/fixture/native_app/package.json
+++ /dev/null
@@ -1,27 +0,0 @@
-{
-  "name": "native-app",
-  "productName": "Native App",
-  "version": "1.0.0",
-  "description": "",
-  "main": "src/index.js",
-  "scripts": {
-    "start": "electron-forge start"
-  },
-  "keywords": [],
-  "author": "",
-  "license": "MIT",
-  "config": {
-    "forge": "./forge.config.js"
-  },
-  "devDependencies": {
-    "ffi-napi": "2.4.5"
-  },
-  "dependencies": {
-    "@nlv8/signun": "1.3.4",
-    "electron-markdown": "0.6.0",
-    "ref-napi": "1.4.2"
-  },
-  "optionalDependencies": {
-    "bcrypt": "3.0.6"
-  }
-}
diff --git a/packages/api/core/test/slow/rebuild_spec_slow.ts b/packages/api/core/test/slow/rebuild_spec_slow.ts
deleted file mode 100644
index 402c2c7725..0000000000
--- a/packages/api/core/test/slow/rebuild_spec_slow.ts
+++ /dev/null
@@ -1,81 +0,0 @@
-import { ForgeArch, ForgePlatform } from '@electron-forge/shared-types';
-import { RebuildOptions } from 'electron-rebuild/lib/src/rebuild';
-import fs from 'fs-extra';
-import path from 'path';
-import os from 'os';
-
-import { expect } from 'chai';
-
-import rebuild from '../../src/util/rebuild';
-import { yarnOrNpmSpawn, hasYarn } from '../../src/util/yarn-or-npm';
-
-describe('rebuilder', () => {
-  const testModulePath = path.resolve(os.tmpdir(), 'electron-forge-rebuild-test');
-
-  async function setupProject() {
-    await fs.remove(testModulePath);
-    await fs.mkdirs(testModulePath);
-    await fs.writeFile(path.resolve(testModulePath, 'package.json'), await fs.readFile(path.resolve(__dirname, '../fixture/native_app/package.json'), 'utf8'));
-    await yarnOrNpmSpawn(hasYarn() ? [] : ['install'], {
-      cwd: testModulePath,
-      stdio: process.platform === 'win32' ? 'inherit' : 'pipe',
-    });
-  }
-
-  async function doRebuild(config?: Partial<RebuildOptions>) {
-    await rebuild(testModulePath, '5.0.12', process.platform as ForgePlatform, process.arch as ForgeArch, config);
-  }
-
-  describe('no config', () => {
-    before(async () => {
-      await setupProject();
-      await doRebuild();
-    });
-
-    it('should have rebuilt top level prod dependencies', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'ref-napi', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'ref-napi build meta should exist').to.equal(true);
-    });
-
-    it('should have rebuilt children of top level prod dependencies', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'cmark-gfm', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'cmark-gfm build meta should exist').to.equal(true);
-    });
-
-    it('should have rebuilt children of scoped top level prod dependencies', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', '@nlv8/signun', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), '@nlv8/signun build meta should exist').to.equal(true);
-    });
-
-    it('should have rebuilt top level optional dependencies', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'bcrypt', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'bcrypt build meta should exist').to.equal(true);
-    });
-
-    it('should not have rebuilt top level devDependencies', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'ffi-napi', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'ffi-napi build meta should not exist').to.equal(false);
-    });
-  });
-
-  describe('with config', () => {
-    before(async () => {
-      await setupProject();
-      await doRebuild({ onlyModules: ['ref-napi'] });
-    });
-
-    it('should have rebuilt module in onlyModules', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'ref-napi', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'ref-napi build meta should exist').to.equal(true);
-    });
-
-    it('should not have rebuilt module not in onlyModules', async () => {
-      const forgeMeta = path.resolve(testModulePath, 'node_modules', 'bcrypt', 'build', 'Release', '.forge-meta');
-      expect(await fs.pathExists(forgeMeta), 'bcrypt build meta should not exist').to.equal(false);
-    });
-  });
-
-  after(async () => {
-    await fs.remove(testModulePath);
-  });
-});