.patches.yaml

repo: src
patches:
-
  owners: alespergl
  file: build_gn.patch
  description: null
-
  owners: alespergl, deepak1556
  file: dcheck.patch
  description: |
    This disables some debug checks which currently fail when running the Electron
    test suite. In general there should be sustained effort to have all debug checks
    enabled. If you want to help, choose one of the diffs below and remove it. Then
    build Electron (debug configuration) and make sure all tests pass on the CI
    systems. Unfortunately the tests don't always cover the check failures, so it's
    good to also run some non-trivial Electron app to verify.

    Apart from getting rid of a whole diff, you may also be able to replace one diff
    with another which enables at least some of the previously disabled checks. For
    example, the checks might be disabled for a whole build target, but actually
    only one or two specific checks fail. Then it's better to simply comment out the
    failing checks and allow the rest of the target to have them enabled.

    Please keep the following lists updated.

    The ELECTRON_NO_DCHECK build flag disables debug checks universally.
    This patch applies the flag to the following GN targets:

      third_party/WebKit/Source/core/loader:loader
      url:url

    These files have debug checks explicitly commented out:

      base/memory/weak_ptr.cc
      base/process/kill_win.cc
      components/viz/service/display/program_binding.h
      content/browser/frame_host/navigation_controller_impl.cc
      content/browser/frame_host/render_frame_host_impl.cc
      content/browser/renderer_host/render_widget_host_view_mac.mm
      ppapi/host/ppapi_host.cc
      third_party/WebKit/Source/core/dom/Node.cpp
      third_party/WebKit/Source/platform/wtf/text/StringImpl.h
      ui/base/clipboard/clipboard_win.cc
-
  owners: zcbenz
  file: accelerator.patch
  description: null
-
  owners: alespergl
  file: allow_new_privs.patch
  description: null
-
  owners: null
  file: app_indicator_icon_menu.patch
  description: null
-
  owners: zcbenz
  file: blink_file_path.patch
  description: null
-
  owners: zcbenz
  file: blink_local_frame.patch
  description: |
    According to electron/electron#3699, it is unreliable to use |unload|
    event for process.exit('exit'), so we have to do that in
    willReleaseScriptContext.

    However Chromium then disallowed scripting in willReleaseScriptContext
    in https://codereview.chromium.org/1657583002, and crash will happen
    when there is code doing that.

    This patch reverts the change to fix the crash in Electron.
-
  owners: null
  file: blink_world_context.patch
  description: null
-
  owners: zcbenz
  file: browser_compositor_mac.patch
  description: null
-
  owners: null
  file: browser_plugin_wheel.patch
  description: null
-
  owners: null
  file: build_toolchain_win_patch.patch
  description: |
    Patch the Windows build toolchain to generate unique PDB names

    When the PDB files generated by the `static_library` build are
    packaged for distribution they are all copied to a single folder,
    some of the PDB files have identical names so they end up
    overwriting each other. The missing PDB files cause linker warnings
    when building Electron in Release mode, and make it more difficult
    to debug release builds.

    This patch modifies the PDB naming convention for the
    `static_library` build configuration to ensure PDB names are unique.
    For example, instead of generating `obj/ui/base/base_cc.pdb` the
    build will now generate `obj/ui/base/obj_ui_base_base_cc.pdb`.
-
  owners: zcbenz
  file: can_create_window.patch
  description: null
-
  owners: null
  file: compositor_delegate.patch
  description: null
-
  owners: null
  file: desktop_screen_win.patch
  description: null
-
  owners: zcbenz
  file: disable_hidden.patch
  description: null
-
  owners: zcbenz
  file: dom_storage_map.patch
  description: null
-
  owners: zcbenz, deepak1556
  file: frame_host_manager.patch
  description: null
-
  owners: tonyganch
  file: latency_info.patch
  description: null
-
  owners: zcbenz
  file: net_url_request_job.patch
  description: null
-
  owners: alexeykuzmin
  file: no_stack_dumping.patch
  description: null
-
  owners: deepak1556
  file: out_of_process_instance.patch
  description: null
-
  owners: alexeykuzmin
  file: protobuf_build_gn.patch
  description: null
-
  owners: null
  file: render_widget_host_view_base.patch
  description: null
-
  owners: zcbenz
  file: render_widget_host_view_mac.patch
  description: null
-
  owners: null
  file: scoped_clipboard_writer.patch
  description: null
-
  owners: deepak1556
  file: stream_resource_handler.patch
  description: null
-
  owners: null
  file: thread_capabilities.patch
  description: |
    Chromium automatically drops all capabilities of renderer threads in
    Linux, which may cause issues in a context like Electron, where the main
    and renderer threads are supposed to keep inherited permissions over the
    system.

    See https://github.com/atom/electron/issues/3666
-
  owners: zcbenz
  file: use_transparent_window.patch
  description: null
-
  owners: null
  file: web_contents.patch
  description: null
-
  owners: miniak
  file: webgl_context_attributes.patch
  description: null
-
  owners: null
  file: webview_cross_drag.patch
  description: null
-
  owners: zcbenz
  file: worker_context_will_destroy.patch
  description: null
-
  owners: null
  file: webui_in_subframes.patch
  description: null
-
  owners: alexeykuzmin
  file: export_blink_webdisplayitemlist.patch
  description: null
-
  owners: alexeykuzmin
  file: statically_build_power_save_blocker.patch
  description: null
-
  owners: gavignus
  file: browser_plugin_guest.patch
  description: null
-
  owners: alexeykuzmin
  file: disable_user_gesture_requirement_for_beforeunload_dialogs.patch
  description: See https://github.com/electron/electron/issues/10754
-
  owners: alexeykuzmin
  file: add_atomic_lib_to_dependencies_even_for_sysroot_builds.patch
  description: null
-
  owners: zcbenz
  file: gin_enable_disable_v8_platform.patch
  description: null
-
  owners: deepak1556
  file: disable-recursive-surface-sync.patch
  description: null
-
  owners: deepak1556
  file: blink-worker-enable-csp-in-file-scheme.patch
  description: null
-
  owners: zcbenz
  file: fix-arm64-linking-error.patch
  description: Do not use system freetype for arm64
-
  owners: brenca
  file: disable-redraw-lock.patch
  description:  |
    Chromium uses a custom window titlebar implementation on Windows when DWM
    is disabled (Windows 7 and earlier, non Aero theme). The native titlebar
    sometimes painted over this custom titlebar, so a workaround was put in
    place to lock redraws in reaction to certain events if DWM is disabled,
    since the code assumes that in that case, the custom titlebar is painted.
    Electron forces the use of the native titlebar, which the workaround doesn't
    take into account, and still locks redraws, causing weird repainting issues
    in electron (and other applications). This patch provides a way to disable
    the redraw locking mechanism, which fixes these issues. The electron issue
    can be found at https://github.com/electron/electron/issues/1821
-
  owners: MarshallOfSound
  file: backport_35dabc0.patch
  description: |
      Backports "ServiceWorker: Fix a jumbo build error",
      see https://chromium-review.googlesource.com/957568
      Original change's landed in 67.0.3369.0.
-
  owners: alexeykuzmin
  file: exclude_next_version_mini_installer_from_deps.patch
  description: |
      It breaks ninja files generation for the "shared_library" configuration.
      Probably won't be needed on the next Chromium upgrade (after 66).
-
  owners: alexeykuzmin
  file: allow_chromiumcontent_to_depend_on_device_service.patch
  description: By default we cannot depend on it, but we want to use it.
-
  owners: nitsakh
  file: v8_context_snapshot_generator.patch
  description: |
      v8_context_snapshot_generator is a build time executable.
      The patch adds the config.
-
  owners: codebytere
  file: backport_953144.patch
  description: |
    Fixes failing <webview> loads devtools extensions registered on the parent
    window test by baking the screencast module into the remote debugging
    configurations of the inspector app. See
    https://chromium-review.googlesource.com/c/chromium/src/+/953144 for more
    details.
-
  owners: alexeykuzmin
  file: backport_ef091c206.patch
  description: |
      https://chromium-review.googlesource.com/969968
      The change originally landed in 67.0.3378.0.
-
  owners: torycl
  file: crashpad-disabled-windows.patch
  description: |
      On Windows Electron does not link Crashpad. This causes linking
      errors with Chromium where it is enabled by default.
      This patch will disable Crashpad in Chromium using fallback
      mechanism which uses Breakpad.
-
  owners: zcbenz
  file: no_cache_storage_check.patch
  description: |
    Do not check for unique origin in CacheStorage, in Electron we may have
    scripts running without an origin.
-
  owners: torycl
  file: backport_e3a883075.patch
  description: |
    https://chromium.googlesource.com/chromium/src/+/e3a883075f699e67ab47d9991ac55b143017cfc3
    The change originally landed in 67.0.3380.0.
-
  owners: zcbenz
  file: scroll_bounce_flag.patch
  description: |
    Patch to make scrollBounce option work.
-
  owners: poiru
  file: backport_d65792a.patch
  description: |
    https://chromium-review.googlesource.com/c/chromium/src/+/1105698
    Fixes https://github.com/electron/electron/issues/13256
-
  owners: zcbenz
  file: webview_reattach.patch
  description: |
    Backports https://chromium-review.googlesource.com/c/chromium/src/+/1161391
    Fixes webview not working after renderer process restarted.
-
  owners: nornagon
  file: mas-cfisobjc.patch
  description: |
    Removes usage of the _CFIsObjC private API.
-
  owners: nornagon
  file: mas-cgdisplayusesforcetogray.patch
  description: |
    Removes usage of the CGDisplayUsesForceToGray private API.
-
  owners: nornagon
  file: mas-audiodeviceduck.patch
  description: |
    Removes usage of the AudioDeviceDuck private API.
-
  owners: nornagon
  file: mas-lssetapplicationlaunchservicesserverconnectionstatus.patch
  description: |
    Removes usage of the _LSSetApplicationLaunchServicesServerConnectionStatus
    private API.
-
  owners: zcbenz
  file: allow_webview_file_url.patch
  description: |
    Allow webview to load non-web URLs.
-
  owners: codebytere
  file: enable_osr_components.patch
  description: |
    Add MouseWheelPhaseHandler for OSR.
-
  owners: deepak1556
  file: content_browser_manifest.patch
  description: |
    Allow content_browser service to access GeolocationControl
    interface from device service.
-
  author: deepak1556 <hop2deep@gmail.com>
  file: vmware_gpu_acceleration.patch
  description: |
    Re-enable GPU acceleration for recent VMWare drivers.
    Backports https://chromium-review.googlesource.com/952778
-
  author: Charles Kerr <charles@charleskerr.com>
  file: allow_nested_error_trackers.patch
  description: |
    Only one X11ErrorTracker should exist at a time, but upstream has a bug
    where two can exist if running in headless mode -- 
      ui::(anonymous namespace)::SupportsEWMH() [inner tracker is created]
      ui::WmSupportsHint()
      ui::IsX11WindowFullScreen()
      ui::ScreensaverWindowFinder::IsScreensaverWindow()
      ui::ScreensaverWindowFinder::ShouldStopIterating()
      ui::EnumerateTopLevelWindows()
      ui::ScreensaverWindowFinder::ScreensaverWindowExists() [outer tracker created]
      ui::CheckIdleStateIsLocked()
      ui::CalculateIdleState()
    Removal of either tracker could have side-effects in some code paths,
    so this is probably better handled upstream. This patch tries to do the
    least harm in the interim by removing the check that prevents more than
    one tracker from existing at a time.
-
  author: Samuel Attard <samuel.r.attard@gmail.com>
  file: blink_initialization_order.patch
  description: |
    Backport of https://chromium-review.googlesource.com/c/chromium/src/+/1030530
    to fix the order of V8 and Blink initialization.  Also fixes order
    of DidCreateScriptContext notification with initialization of window globals
    to fix electron/electron#13787.  The backport landed in Chromium 67 but the
    DidCreateScriptContext re-ordering needs to be upstreamed or kept indefinitely
-
  author: zcbenz <zcbenz@gmail.com>
  file: disable_detach_webview_frame.patch
  description: |
    Don't detach the frame for webview, we will manage the WebContents
    manually.
    This is part of the fixes for https://github.com/electron/electron/issues/14211.
    We should revisit this bug after upgrading to newer versions of Chrome,
    this patch was introduced in Chrome 66.
-
  author: Shelley Vohr <shelley.vohr@gmail.com>
  file: libgtkui_export.patch
  description: |
    Export libgtkui symbols for the GN component build.
-
  author: zcbenz <zcbenz@gmail.com>
  file: web_preferences.patch
  description: |
    Add a node_integration field to WebPreferences so we can determine whether
    a frame has node integration in renderer process.

    This is required by the nativeWindowOpen option, which put multiple main
    frames in one renderer process.
-
  author: deepak1556 <hop2deep@gmail.com>
  file: proxy_resolution_win_http.patch
  description: |
    Backport https://chromium-review.googlesource.com/c/chromium/src/+/1143093
    Fixes proxy resolution from pac file with ws(s) requests when using platform
    proxy resolvers on windows and macOS.
-
  owners: alexeykuzmin
  file: backport_6c41b439b.patch
  description: |
    Backports http://crrev.com/6c41b439b9e299354f86b91426ff0f7196c13f90
    SQLitePersistentCookieStore: recover from uniqueness violation on V9->V10 migration
-
  author: deepak1556 <hop2deep@gmail.com>
  file: proxy_config_monitor.patch
  description: |
    Allows building //chrome proxy sources for Electron.
-
  owners: zcbenz
  file: fix_trackpad_scrolling.patch
  description: |
    Backport https://chromium-review.googlesource.com/c/chromium/src/+/1299342