Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled binaries downloaded by mksnapshot broken? #3

Closed
ghost opened this issue Apr 7, 2017 · 14 comments
Closed

Compiled binaries downloaded by mksnapshot broken? #3

ghost opened this issue Apr 7, 2017 · 14 comments

Comments

@ghost
Copy link

ghost commented Apr 7, 2017

Looks like mksnapshot compiled binaries downloaded by electron-mksnapshot wrong compiled. When I downloading prebuilt binaries for arm/armv7l I got Intel 80836 binaries.
file mksnapshot output:
mksnapshot: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.26, BuildID[sha1]=8b1a63cf158c934666279b6539cfa945502264c5, not stripped

So, I'd like to compile mksnapshot separately from Electron on my machine, where i can found sources for it?

@ghost ghost changed the title Is there a source files of compiled mksnapshots binaries? Compiled binaries downloaded by mksnapshot broken? Apr 9, 2017
@ghost
Copy link
Author

ghost commented May 2, 2017

Any news? :(

@kevinsawicki
Copy link
Contributor

@hypersad which version of mksnapshot and electron are you using?

@ghost
Copy link
Author

ghost commented May 4, 2017

@kewinsawicki I need mksnapshot for building Atom. Defined electronVersion to 1.6.0 and mksnapshot to ~1.6 in package.json.

@kevinsawicki
Copy link
Contributor

@hypersad can you try setting running:

npm --arch=armv7l --platform=linux install electron-mksnapshot@1.6.0

and see if that downloads the right version?

@ghost
Copy link
Author

ghost commented May 5, 2017

I'll try it when i come home, but didn't think that it help me, because I tried some versions from china mirror and they returns Intel 80836

@ghost
Copy link
Author

ghost commented May 7, 2017

Still getting Intel 80836 binaries...
Install log can be found here

@kevinsawicki
Copy link
Contributor

@hypersad can you download https://github.com/electron/electron/releases/download/v1.6.0/mksnapshot-v1.6.0-linux-armv7l.zip directly and confirm it works as expected?

@ghost
Copy link
Author

ghost commented May 17, 2017

Again Intel 80836, again 'Exec format error'...

@ghost
Copy link
Author

ghost commented May 31, 2017

Any news? We need mksnapshot for trying to build Atom on armv7l :(

@ghost
Copy link
Author

ghost commented Jun 20, 2017

Maybe I should create an issue in electron?

@mathuin
Copy link

mathuin commented Dec 14, 2017

@hypersad I made an issue electron/electron#11413 because I didn't know mksnapshot had its own repository. This problem has not yet been fixed, and now your unmaintained repository no longer builds -- not your fault, that's what unmaintained means. :-) I am hopeful that whoever does maintain mksnapshot can somehow get it to build for ARM now that electron-packager supports ARM, because I think that's the last roadblock preventing master-branch Atom from being compiled for armv7l.

@zeke
Copy link

zeke commented Dec 14, 2017

@jkleinsc is actively working on resolving the mksnapshot issue, and I believe he cut a new release today.

@mathuin
Copy link

mathuin commented Dec 14, 2017

I find that very exciting! What can I do to test it?

@jkleinsc
Copy link
Contributor

jkleinsc commented May 4, 2018

Starting with version 1.8.5 (as well as 2.0.0-beta7), we changed how we distribute the arm/arm64 binaries of mksnapshot. There are now 4 files for arm/arm64 mksnapshot, for example the following from the 2.0.0 release:

  • mksnapshot-v2.0.0-linux-arm-x64.zip - intel x64 binary that produces snapshots suitable for using on armv7 hardware.
  • mksnapshot-v2.0.0-linux-arm.zip - armv7 binary that produces snapshots suitable for using on armv7 hardware.
  • mksnapshot-v2.0.0-linux-arm64-x64.zip - intel x64 binary that produces snapshots suitable for using on armv8(arm64) hardware.
  • mksnapshot-v2.0.0-linux-arm64.zip -armv8(arm64) binary that produces snapshots suitable for using on armv8(arm64) hardware.

Because of these changes, when you now run npm install with an electron-mksnapshot dependency on arm or arm64 hardware you will get the binary that can actually run on those platforms.

@jkleinsc jkleinsc closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants