Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: can't run test suite locally on MacOS arm64 #1392

Open
3 tasks done
VerteDinde opened this issue Aug 2, 2022 · 1 comment
Open
3 tasks done

[test]: can't run test suite locally on MacOS arm64 #1392

VerteDinde opened this issue Aug 2, 2022 · 1 comment
Labels

Comments

@VerteDinde
Copy link
Member

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Packager Version:
    • main/15.5.0
  • Electron Version:
    • Electron 6.0.0 (headers used in test suite)
  • Operating System:
    • macOS 12.4.0 arm64
  • Last Known Working Electron Packager version::
    • N/A, issue is specific to Apple Silicon

Expected Behavior

Running ./test/ci/before_install.sh and npm test should run the test suite locally.

Actual Behavior

Running npm test works as expected on x64, but fails on arm64 with the following error:

Downloading Electron v1.4.13 before running tests...
HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v6.0.0/electron-v6.0.0-darwin-arm64.zip

This is almost certainly because Electron 6 was released before arm64 was available, and there was no version of Electron being built for arm64. While there are several tests that depend on testing specific Electron versions (e.g. 6.0.0), we may want to modify tests that don't depend on those versions to be able to run locally on an arm64 machine.

@welcome
Copy link

welcome bot commented Aug 2, 2022

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant