Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] What extra steps does electron-build take over node-gyp? #360

Closed
glenn2223 opened this issue Mar 18, 2020 · 1 comment
Closed
Labels

Comments

@glenn2223
Copy link

glenn2223 commented Mar 18, 2020

Firstly, sorry for dropping this on an issue (don't know of any other way to ask a question on github).

Ref: sass/node-sass#2862

Is there any inner workings of electron-rebuild that will stop me from running this

node-gyp rebuild --target=8.0.0 --arch=x64 --dist-url=https://electronjs.org/headers

rather than this

./node_modules/.bin/electron-rebuild -v=8 --arch=x64 -w node-sass

After doing this npm config set msbuild_path "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe" to suppress the VS19 folder name issue with node-sass's native node-gyp@3.8.0

@malept malept added the question label Apr 3, 2020
@malept
Copy link
Member

malept commented Apr 3, 2020

For your use case, I would suggest prebuild - electron-rebuild's primary use case is rebuilding native modules for Electron apps, not providing build machinery for native modules.

@malept malept closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants