Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing app #81

Merged
merged 1 commit into from Nov 2, 2023
Merged

fix: add missing app #81

merged 1 commit into from Nov 2, 2023

Conversation

soroushm
Copy link
Contributor

@soroushm soroushm commented Nov 2, 2023

fix missing app in index.js
issue #80

Copy link
Member

@erikian erikian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erikian erikian changed the title add missing app fix: add missing app Nov 2, 2023
@erikian erikian merged commit 52fa9a2 into electron:main Nov 2, 2023
9 of 10 checks passed
Copy link

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@soroushm soroushm deleted the fix/missingApp branch November 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError, as app is not defined as of @electron/universal@1.4.2
2 participants