Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import for path now compiles correctly after TypeScript was added #85

Merged
merged 2 commits into from Nov 5, 2023
Merged

fix: import for path now compiles correctly after TypeScript was added #85

merged 2 commits into from Nov 5, 2023

Conversation

BaldvinTh
Copy link
Contributor

This PR fixes issue #84

@BaldvinTh BaldvinTh requested a review from a team as a code owner November 4, 2023 11:53
@BaldvinTh BaldvinTh changed the title Fixing import for path after TypeScript was added fix: import for path now compiles correctly after TypeScript was added Nov 4, 2023
erikian
erikian requested changes Nov 4, 2023
View reviewed changes
Copy link
Member

@erikian erikian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'd prefer to add "esModuleInterop": true to tsconfig.json so we don't break things again because of a wrong import style.

@BaldvinTh
Copy link
Contributor Author

I enabled esModuleInterop, and fixed the import * as that broke the build. Other import * as I did not touch in this commit.

@erikian erikian linked an issue Nov 5, 2023 that may be closed by this pull request
Uncaught ReferenceError, as path.default is not defined as of @electron/universal@1.4.4 #84
Closed
@erikian erikian merged commit 02119d5 into electron:main Nov 5, 2023
9 checks passed
@continuous-auth Continuous Auth
Copy link

🎉 This PR is included in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikian erikian erikian approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError, as path.default is not defined as of @electron/universal@1.4.4
2 participants
@BaldvinTh @erikian