Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "see more" of one of the card also stretches other card #200

Open
mohantechnology opened this issue Mar 29, 2022 · 7 comments
Open

Comments

@mohantechnology
Copy link

mohantechnology commented Mar 29, 2022

In electron website governance page
when clicked on "see more" of one of the card , then other cards also stretches to the height of the clicked card

issue-electron.mp4

is it made to behave like that ?
or we can update it to work like below

solved.mp4
@erickzhao erickzhao transferred this issue from electron/electronjs.org-old Mar 30, 2022
@molant
Copy link
Contributor

molant commented Mar 30, 2022

@mohantechnology I think your option makes sense. @erickzhao what do you think?

@mohantechnology
Copy link
Author

do i make a pull request regarding this changes ?

@molant
Copy link
Contributor

molant commented Apr 1, 2022

yes, please!

@mohantechnology
Copy link
Author

mohantechnology commented Apr 2, 2022

In below screenshots, height of card description is different for some card therefore , some "member" and "see more" horizontal position is not matched with their neighbour card
Screenshot (4386)

so to fix this i have added a css class to handle height of card description . please take a look here and let me know if i have to make some changes .

after fixing final result is

screen-capture.5.mp4

@rajpatelbot
Copy link

Hey @mohantechnology, can i make pull request to solve this problem??

@erickzhao
Copy link
Member

There's already a PR up for this. #202

@mdirfan40
Copy link

is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants