Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the system menu dark themed when using the dark theme #8680

Closed
turt2live opened this issue Feb 15, 2019 · 5 comments
Closed

Make the system menu dark themed when using the dark theme #8680

turt2live opened this issue Feb 15, 2019 · 5 comments
Labels
A-Electron P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Enhancement

Comments

@turt2live
Copy link
Member

This might be hard, because Windows.
@yangm97
Copy link

yangm97 commented Feb 15, 2019

screen shot 2019-02-15 at 01 08 54

There are some possible solutions on macOS:

  1. Use the native dark theme API
    Works only on Mojave and later.

  2. Use the native bar tint API
    Seems to work as far as Yosemite (afaik), is used by Sublime Text, Telegram, etc. Can be tinted with any color.

  3. Ignore the title bar completely and add system buttons on top
    Idk if there's an API for that, but it looks like most electron apps pick this one so it shouldn't be hard.

@starcraft66
Copy link

This would be really, really, really appreciated!

@starcraft66
Copy link

Upon further inspection, a quick and dirty way of getting this working on macOS 10.14+ is setting the NSRequiresAquaSystemAppearance to false in the application's Info.plist file as per https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app.

However, electron also apparently has built-in APIs to manage the title bar colour: electron/electron#13387

@Timsuper
Copy link

would be nice

@lampholder lampholder added feature P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users A-Electron labels Feb 26, 2019
@dbkr
Copy link
Member

dbkr commented Nov 19, 2019

Fixed by #11140

@dbkr dbkr closed this as completed Nov 19, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Jun 7, 2022
@su-ex
Merge tag 'v1.10.14' into sc
4b5042b 
* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327.
* Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883.
* Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)).
* Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337.
* Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788.
* Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279.
* Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244.
* Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Electron P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jryans @dbkr @turt2live @starcraft66 @lampholder @yangm97 @Timsuper