Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in notification for reply in thread is not well formatted #2568

Open
bmarty opened this issue Mar 19, 2024 · 0 comments · May be fixed by #2569
Open

Text in notification for reply in thread is not well formatted #2568

bmarty opened this issue Mar 19, 2024 · 0 comments · May be fixed by #2569
Assignees
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bmarty
Copy link
Member

bmarty commented Mar 19, 2024

Steps to reproduce

  1. Alice and Bob are in a room A
  2. Alice opens room A
  3. Alice sends a message "Message"
  4. Bob sees a notification with this message and dismiss it, just to clear the notification panel
  5. Alice starts a thread from this message
  6. Alice reply to the first message with the text "Reply", in the thread

Observe the notification rendering on Bobs device

Note: the issue is not observed when replying to a message but not in a thread. In this case, the notification will only contains the reply. This is maybe another issue which is out of scope of this one.

Outcome

What did you expect?

  • In reply to is localized
  • the replied message should not be rendered, for long message, the reply content will not be visible
  • The expected content should be something like (for instance in French):
En réponse à @alice:matrix.org: Reply

What happened instead?

In reply to@alice:domain.org
MessageReply

4 problems:

  • In reply to is not localized
  • A space is missing before the userId
  • The first message is rendered
  • The first message and the reply are not separated by a space.

Your phone model

Any

Operating system version

Any

Application version and app store

0.4.6

Homeserver

Any

Will you send logs?

No

Are you willing to provide a PR?

Yes

@bmarty bmarty added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 19, 2024
@bmarty bmarty self-assigned this Mar 19, 2024
@bmarty bmarty linked a pull request Mar 19, 2024 that will close this issue
14 tasks
frebib pushed a commit to frebib/element-x-android that referenced this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant