Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message context menu overlaps Screen lock pin #2692

Closed
VolkerJunginger opened this issue Apr 12, 2024 · 2 comments · Fixed by #2874
Closed

Message context menu overlaps Screen lock pin #2692

VolkerJunginger opened this issue Apr 12, 2024 · 2 comments · Fixed by #2874
Assignees
@ganfra
Labels
A-PIN Code T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@VolkerJunginger
Copy link

Steps to reproduce

Have EX installed and screen lock activated.

  • Open a conversation.
  • Go to a message an long tap to open the context menue (like, forward ...)
  • Put app to background
  • Bring app to foreground and try to log in.
    --> The context menue is still visible and overlaps the pin code screen

image

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@VolkerJunginger VolkerJunginger added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 12, 2024
@ganfra
Copy link
Contributor

ganfra commented May 16, 2024

@VolkerJunginger is it acceptable to just close the context menu in this case?

@ganfra ganfra self-assigned this May 16, 2024
@VolkerJunginger
Copy link
Author

yes, that's fine. It does not have to be persisted.

ganfra added a commit that referenced this issue May 17, 2024
@ganfra
Fix modal contents overlapping screen lock pin #2692
b0c369e
@ganfra ganfra mentioned this issue May 17, 2024
Merged
14 tasks
ganfra added a commit that referenced this issue May 20, 2024
@ganfra
Pin : clean up after PR review #2692
a19f69a
ganfra added a commit that referenced this issue May 20, 2024
@ganfra
Pin : clean up after PR review #2692
73905fa
ganfra added a commit that referenced this issue May 21, 2024
@ganfra
Merge pull request #2874 from element-hq/feature/fga/fix_2692
ac123bd 
Fix modal contents overlapping screen lock pin #2692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
A-PIN Code T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix modal contents overlapping screen lock pin #2692 element-hq/element-x-android
2 participants
@ganfra @VolkerJunginger