Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome Autofills Security Key #380

Open
hanthor opened this issue Jun 2, 2021 · 3 comments · May be fixed by #616
Open

Chrome Autofills Security Key #380

hanthor opened this issue Jun 2, 2021 · 3 comments · May be fixed by #616
Assignees
@aaryan-gautam
Labels
bug Something isn't working good first issue Good for newcomers minor

Comments

@hanthor
Copy link

hanthor commented Jun 2, 2021

Describe the bug
Good Chrome thinks the security key field in Settings is a password field and will autofill

To Reproduce
Steps to reproduce the behavior:

  1. Open settings in hydrogen on Google Chrome with a save credentialf ro the site
  2. Chrome will autofile the secutiy key and the search bar with your username and password

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows and Linux
  • Browser Chrome
@bwindels bwindels added the bug Something isn't working label Jun 2, 2021
@bwindels
Copy link
Contributor

bwindels commented Jun 2, 2021

Thanks for reporting. I should probably give the password (and other) fields a name attribute :)

@bwindels bwindels added minor help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jun 2, 2021
@aaryan-gautam
Copy link

Can I look into this issue?

@MidhunSureshR
Copy link
Contributor

MidhunSureshR commented Nov 28, 2021 •
edited

Here's what MDN says about the autocomplete attribute:

Note: In order to provide autocompletion, user-agents might require <input>/<select>/<textarea> elements to:

  1. Have a name and/or id attribute
  2. Be descendants of a element
  3. The form to have a submit button

So to turn off autocomplete for these fields, you would need to wrap the inputs in a <form> tag.

@aaryan-gautam aaryan-gautam linked a pull request Dec 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaryan-gautam aaryan-gautam

Labels
bug Something isn't working good first issue Good for newcomers minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed autocomplete bug by enclosing div within a form tag #380 aaryan-gautam/hydrogen-web
4 participants
@bwindels @hanthor @MidhunSureshR @aaryan-gautam