Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ratelimit from rooms /state, /redact and /send #17190

Closed
wants to merge 4 commits into from

Conversation

kfiven
Copy link

@kfiven kfiven commented May 14, 2024

Pull Request Checklist

Fixes #17188

As per spec these endpoints are not rate limited.

https://spec.matrix.org/v1.10/client-server-api/#put_matrixclientv3roomsroomidstateeventtypestatekey

https://spec.matrix.org/v1.10/client-server-api/#put_matrixclientv3roomsroomidredacteventidtxnid

https://spec.matrix.org/v1.10/client-server-api/#put_matrixclientv3roomsroomidsendeventtypetxnid

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@kfiven kfiven requested a review from a team as a code owner May 14, 2024 07:51
@kfiven kfiven changed the title Remove ratelimit from /state, /redact and /send Remove ratelimit from rooms /state, /redact and /send May 14, 2024
@erikjohnston
Copy link
Member

Hi, sorry but we're not going to remove ratelimiting, as they mitigate spam and general abuse. See the issue for more details: #17188

@kfiven kfiven deleted the patch-1 branch May 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT /state is rate limited against spec
2 participants