Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a way to specify header values from on_* methods of subclasses of BaseFederationServerServlet #17196

Open
H-Shay opened this issue May 14, 2024 · 0 comments
Open

Develop a way to specify header values from on_* methods of subclasses of BaseFederationServerServlet #17196

H-Shay opened this issue May 14, 2024 · 0 comments
Labels
T-Task

Comments

@H-Shay
Copy link
Contributor

H-Shay commented May 14, 2024

Currently when instantiating a subclass of BaseFederationServerServlet, and calling one of it's on_* methods the same arguments are passed in for all functions, resulting in needing to special-case when a function requires different arguments (ie see the discussion at https://github.com/element-hq/synapse/pull/17172/files/b6803f6049a823ca2c76da129c790728257e4ef4#r1594778790). Is there a more graceful way to do this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikjohnston @H-Shay