Replies: 4 comments
-
@purepear Yes, remove |
Beta Was this translation helpful? Give feedback.
-
@purepear It is definitely worth a PR for removing |
Beta Was this translation helpful? Give feedback.
-
Thanks guys, i'll look at the other PR and see if i can raise a new PR during the weekend :) |
Beta Was this translation helpful? Give feedback.
-
Here's what i came up with #3356 All feedback appreciated. We can continue the discussion inside the PR comments 😄 |
Beta Was this translation helpful? Give feedback.
-
Big thanks for the incredible work on Element-plus!
Here is an idea that probably doesn't fit in the issues section :)
Maybe i'm missing something but i don't see a reason why we couldn't use simple methods instead of mitt events when we add/remove form fields in a form. We already use
provide
/inject
and the mitt events doesn't seem necessary. 🤔 Pls correct me if i'm wrong and this is used in some other ways or has a potential to be a breaking change. (Does the async nature of the events really help in this situation?)In form.vue we have:
That can become sth like:
// We can put these methods on the elForm
provide
and get rid of formMittAnd then in form-item.vue we have:
That can become sth like:
What do you think guys? Is it worth raising a PR? :)
Beta Was this translation helpful? Give feedback.
All reactions