Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table] fixed column supported in grouped header #10096

Merged
merged 10 commits into from Oct 23, 2022
Merged

fix(components): [table] fixed column supported in grouped header #10096

merged 10 commits into from Oct 23, 2022

Conversation

tinyfind
Copy link
Contributor

@tinyfind tinyfind commented Oct 14, 2022 •
edited

close #9216,close #3670,close #6949

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @tinyfind, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Oct 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 14, 2022 •
edited

@github-actions
Copy link

Hello @tinyfind, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 15, 2022
@github-actions
Copy link

github-actions bot commented Oct 15, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10096
Please comment the example via this playground if needed.

@tolking tolking requested a review from a team October 15, 2022 13:38
@tolking
Copy link
Member

tolking commented Oct 15, 2022

demo

before

@tolking
Copy link
Member

tolking commented Oct 18, 2022

Can you add a test, and add an example for documentation?

@tinyfind
Copy link
Contributor Author

tinyfind commented Oct 19, 2022 •
edited

Can you add a test, and add an example for documentation?

ok, please review again

@tolking
Copy link
Member

tolking commented Oct 19, 2022

Some files have conflicts that need to be resolved

@tinyfind
Copy link
Contributor Author

Some files have conflicts that need to be resolved

resolved

tolking
tolking approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tinyfind tinyfind requested review from tolking and holazz and removed request for tolking October 23, 2022 09:20
@tolking tolking merged commit 9285109 into element-plus:dev Oct 23, 2022
@Tsong-LC Tsong-LC mentioned this pull request Nov 1, 2022
Closed
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@holazz holazz Awaiting requested review from holazz

Assignees

@tinyfind tinyfind

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@tinyfind @tolking @holazz