Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [calendar] #10163

Merged
merged 2 commits into from Oct 22, 2022
Merged

refactor(components): [calendar] #10163

merged 2 commits into from Oct 22, 2022

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Oct 21, 2022

  • Eliminate long function by extracting code as function calls.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@jw-foss jw-foss requested a review from a team October 21, 2022 01:45
@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 21, 2022
@jw-foss
refactor(components): [calendar]
f55908f 
* Eliminate long function by extracting code as function calls.
@jw-foss jw-foss force-pushed the refactor/extract-logic-code-from-component-calendar branch from 33c9828 to f55908f Compare October 21, 2022 01:49
@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10163
Please comment the example via this playground if needed.

@jw-foss jw-foss merged commit d3a32cd into dev Oct 22, 2022
@jw-foss jw-foss deleted the refactor/extract-logic-code-from-component-calendar branch October 22, 2022 03:39
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@emojiiii emojiiii emojiiii approved these changes

Assignees

@jw-foss jw-foss

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jw-foss @holazz @ryuhangyeong @emojiiii