Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [carousel] #10188

Merged
merged 2 commits into from Oct 24, 2022
Merged

refactor(components): [carousel] #10188

merged 2 commits into from Oct 24, 2022

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Oct 22, 2022

  • Extract component logic out of .vue file.
  • Reorganize code for better readability.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@jw-foss jw-foss requested a review from a team October 22, 2022 04:46
@github-actions
Copy link

github-actions bot commented Oct 22, 2022 •
edited

@jw-foss jw-foss force-pushed the refactor/extract-logic-out-of-component-carousel branch from 713d029 to abcad05 Compare October 22, 2022 04:47
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 22, 2022
@jw-foss
refactor(components): [carousel]
e792852 
* Extract component logic out of .vue file.
* Reorganize code for better readability.
@jw-foss jw-foss force-pushed the refactor/extract-logic-out-of-component-carousel branch from abcad05 to e792852 Compare October 22, 2022 04:49
@github-actions
Copy link

github-actions bot commented Oct 22, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10188
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong requested review from ryuhangyeong and a team October 24, 2022 11:21
@holazz holazz enabled auto-merge (squash) October 24, 2022 12:44
@holazz holazz merged commit 9046055 into dev Oct 24, 2022
@holazz holazz deleted the refactor/extract-logic-out-of-component-carousel branch October 24, 2022 12:47
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

@ryuhangyeong ryuhangyeong Awaiting requested review from ryuhangyeong

Assignees

@jw-foss jw-foss

Labels
CommitMessage::Qualified Qualified commit message Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jw-foss @holazz @ryuhangyeong