Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): [table] can't select row children #10221

Merged
merged 19 commits into from Nov 5, 2022

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Oct 24, 2022

#10080
Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @faga1, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

@github-actions
Copy link

Hello @faga1, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

🧪 Playground Preview: https://element-plus.run/?pr=10221
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented Oct 26, 2022

bug

Demo

toggleRowStatus fix
@faga295
Copy link
Contributor Author

faga295 commented Oct 30, 2022

I moved toggleRowStatus into usewatcher because toggleRowSelection should be trigger inside toggleRowStatus

@AxelConceicao
Copy link

Thanks for this awesome feature|fix

@tolking tolking requested a review from a team November 5, 2022 09:10
@jw-foss jw-foss merged commit d2fb4ff into element-plus:dev Nov 5, 2022
@element-bot element-bot mentioned this pull request Nov 6, 2022
3 tasks
@wubianluoye
Copy link

当使用tree-props重新定义children为其他非children字符串时,如 :tree-props="{children: 'list'}"点击父节点无法选中子节点

@tolking
Copy link
Member

tolking commented Nov 8, 2022

@jw-foss I suddenly realized that there might be a problem with this PR.

Each data in the table is independent of each other, and the select should be same. consistent with element ui

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants