Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [form] throw non-validation error #10255

Merged
merged 1 commit into from Oct 26, 2022
Merged

fix(components): [form] throw non-validation error #10255

merged 1 commit into from Oct 26, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Oct 26, 2022 •
edited

closes #10250

Before

image

After

image

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 26, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=10255
Please comment the example via this playground if needed.

btea
btea approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jw-foss jw-foss merged commit 4a26aa4 into dev Oct 26, 2022
@jw-foss jw-foss deleted the fix/form_validate branch October 26, 2022 15:18
@jw-foss
Copy link
Member

jw-foss commented Oct 26, 2022

Merged 🚀

@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [form] Logical problem with validate method on el-form
4 participants
@holazz @jw-foss @btea @ryuhangyeong