Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [collapse] #10289

Merged
merged 2 commits into from Oct 31, 2022
Merged

refactor(components): [collapse] #10289

merged 2 commits into from Oct 31, 2022

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Oct 27, 2022

  • Extract logic code out of component file.
  • Extract DOM code out of component file.
  • Reorganize code for better readabilities.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@jw-foss
refactor(components): [collapse]
05a7da5 
* Extract logic code out of component file.
* Extract DOM code out of component file.
* Reorganize code for better readabilities.
@jw-foss jw-foss requested a review from a team October 27, 2022 13:40
@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10289
Please comment the example via this playground if needed.

chenxch
chenxch approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is pretty cool.

@jw-foss jw-foss merged commit 4ff8f28 into dev Oct 31, 2022
@jw-foss jw-foss deleted the refactor/extract-logic-out-of-component-collapse branch October 31, 2022 16:27
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

@chenxch chenxch chenxch approved these changes

@btea btea btea approved these changes

Assignees

@jw-foss jw-foss

Labels
CommitMessage::Qualified Qualified commit message Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jw-foss @holazz @chenxch @btea