Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): [vnode] flattedChildren support subTree #10298

Merged
merged 3 commits into from Oct 31, 2022
Merged

fix(utils): [vnode] flattedChildren support subTree #10298

merged 3 commits into from Oct 31, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Oct 28, 2022

close #10284

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Oct 28, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 28, 2022
@github-actions
Copy link

github-actions bot commented Oct 28, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10298
Please comment the example via this playground if needed.

@chenxch
Copy link
Member Author

chenxch commented Oct 29, 2022

/cc @buqiyuan PTAL

@init-qy
Copy link
Contributor

init-qy commented Oct 29, 2022

aslo close #9334

@chenxch
Copy link
Member Author

chenxch commented Oct 29, 2022

aslo close #9334

Maybe you say #10292 ?

@init-qy
Copy link
Contributor

init-qy commented Oct 29, 2022

aslo close #9334

Maybe you say #10292 ?

yes, sorry about this

@chenxch
Copy link
Member Author

chenxch commented Oct 29, 2022

yes, sorry about this

Never mind, thanks for your feedback.

@holazz
Copy link
Member

holazz commented Oct 30, 2022

Doesn't seem to work on my machine.🤔 Playground

@chenxch
Copy link
Member Author

chenxch commented Oct 30, 2022

Doesn't seem to work on my machine.🤔 Playground

Received, I will investigate.

@chenxch
Copy link
Member Author

chenxch commented Oct 30, 2022

/cc @ryuhangyeong @holazz PTAL.

@holazz holazz merged commit b45346c into dev Oct 31, 2022
@holazz holazz deleted the fix/flattedChildren-subTree branch October 31, 2022 08:21
@init-qy init-qy mentioned this pull request Nov 1, 2022
Closed
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuhangyeong ryuhangyeong ryuhangyeong left review comments

@holazz holazz holazz approved these changes

@btea btea btea approved these changes

@buqiyuan buqiyuan buqiyuan approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [tab-pane, table] 2.2.18之后，el-tabs无法识别子组件的el-tab-pane
6 participants
@chenxch @init-qy @holazz @btea @ryuhangyeong @buqiyuan