Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [carousel] missing root ref #10312

Merged
merged 1 commit into from Oct 30, 2022
Merged

fix(components): [carousel] missing root ref #10312

merged 1 commit into from Oct 30, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Oct 30, 2022 •
edited

Before

image

After

image

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Oct 30, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 30, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=10312
Please comment the example via this playground if needed.

@xiaoxian521 xiaoxian521 self-requested a review October 30, 2022 03:18
@holazz holazz merged commit 93f2a1d into dev Oct 30, 2022
@holazz holazz deleted the fix/carousel_root-ref branch October 30, 2022 08:27
@jw-foss
Copy link
Member

jw-foss commented Oct 31, 2022

Apologies for the late response 🙇 and thanks for fixing this

@holazz
Copy link
Member Author

holazz commented Oct 31, 2022

Apologies for the late response 🙇 and thanks for fixing this

Haha, little problem.

@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@holazz @jw-foss @btea @ryuhangyeong @xiaoxian521