Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tree-v2] default icon render test #10342

Merged
merged 2 commits into from Nov 1, 2022
Merged

fix(components): [tree-v2] default icon render test #10342

merged 2 commits into from Nov 1, 2022

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Nov 1, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

add test for #10340

@pull-request-triage
Copy link

👋 @init-qy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10342
Please comment the example via this playground if needed.

holazz
holazz reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@holazz holazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment for your consideration.

packages/components/tree-v2/__tests__/tree.test.ts Outdated Show resolved Hide resolved
@init-qy @holazz
Update packages/components/tree-v2/__tests__/tree.test.ts
6f5f7bc 
Co-authored-by: zz <2418184580@qq.com>
@init-qy init-qy requested a review from holazz November 1, 2022 03:54
@holazz holazz enabled auto-merge (squash) November 1, 2022 04:03
@holazz holazz merged commit d8ee83d into element-plus:dev Nov 1, 2022
@init-qy init-qy deleted the fix/tree-v2-test branch November 2, 2022 03:25
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

Assignees

@init-qy init-qy

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@init-qy @holazz