Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] fix placeholder display #11051

Merged
merged 3 commits into from
May 13, 2023

Conversation

sleepyShen1989
Copy link
Contributor

@sleepyShen1989 sleepyShen1989 commented Dec 21, 2022

closed #11049

动态修改placeholder时,判断modelValue是否有值,如果有值则清空placeholder

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @sleepyShen1989, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

@github-actions
Copy link

Hello @sleepyShen1989, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

🧪 Playground Preview: https://element-plus.run/?pr=11051
Please comment the example via this playground if needed.

@btea btea mentioned this pull request May 9, 2023
3 tasks
@Lionad-Morotar
Copy link
Contributor

@btea Hello, would this pr being merged in the next release?

@btea
Copy link
Collaborator

btea commented May 10, 2023

@Lionad-Morotar Also needs to be reviewed by other team members. Please be patient.

@btea btea merged commit 44376fa into element-plus:dev May 13, 2023
This was referenced May 19, 2023
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants