Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [message-box] remove useRestoreActive #11646

Merged
merged 2 commits into from
May 28, 2023
Merged

refactor(components): [message-box] remove useRestoreActive #11646

merged 2 commits into from
May 28, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Feb 18, 2023 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

This useRestoreActive hook is redundant at present. It is already included in the FocusTrap component. Link #11586

before

after

@github-actions
Copy link

github-actions bot commented Feb 18, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 18, 2023
@github-actions
Copy link

github-actions bot commented Feb 18, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=11646
Please comment the example via this playground if needed.

btea
btea approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btea btea requested review from chenxch and ryuhangyeong May 27, 2023 08:27
@btea btea merged commit 6222629 into dev May 28, 2023
9 checks passed
@btea btea deleted the refactor/message-box-blur branch May 28, 2023 01:57
@element-bot element-bot mentioned this pull request Jun 2, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@tolking @dannyhebertbell
refactor(components): [message-box] remove useRestoreActive (element-…
37e8092 
…plus#11646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@chenxch chenxch Awaiting requested review from chenxch

Assignees

@tolking tolking

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tolking @btea @ryuhangyeong